On Wed, 2009-02-11 at 16:26 +0100, Jan Engelhardt wrote: > On Tuesday 2009-02-10 22:37, jamal wrote: > > > >As i mentioned to Jan I would like to unify that into > >a simple call: > > > >----------- > > xtables_init_all(&tcxt_globals); > >---------- > > > >Then I will be more confident that we we will have peace going > >forward. Please let me know if this is acceptable and i will > >prepare a patch. > > Ok. Ok, goody - I actually had almost finished it; have some cycles. I will post shortly. > > >+extern void xtables_free_opts(int reset_offset); > >+extern void xtables_set_revision(char *name, u_int8_t revision); > > You need const char * to avoid warnings. Ok. > >diff --git a/xtables.c b/xtables.c > >index 805b940..48b4104 100644 > >--- a/xtables.c > >+++ b/xtables.c > >@@ -99,6 +99,8 @@ void xtables_free_opts(int reset_offset) > > } > > } > > > >+void xtables_set_revision_ipv4(char *name, u_int8_t revision); > >+void xtables_set_revision_ipv6(char *name, u_int8_t revision); > > > > struct option * > > xtables_merge_options(struct option *oldopts, const struct option *newopts, > > Why are these prototypes here? (You can make the functions static > and reorder to leave them out.) > True. > Since IPT_FUNCTION_MAXNAMELEN is the same as IP6T_FUNCTION_MAXNAMELEN, > these functions can be consolidated. > Shouldve checked that. Ok, since this patch hasnt been merged; i will resend it and i dont see the need for a callback in xtables_globals Thanks for all the feedback Jan. cheers, jamal -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
