Re: RFC: introduce xtables global param struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Saturday 2009-02-07 20:28, jamal wrote:
>
>I would like to introduce this new struct so as to pass 
>localize the globals used and help in symbol renames. 

Please post patch inline. I otherwise need to save them
and reinsert them into alpine..

>xtables_set_params() is intended to free xtables from depending
>(as it does right now) on existence of such externally definitions
>(from iptables/iptables6 etc).
> 
>Ive included a sample user - xtables_free_opts() to show
>how i plan to use it.
>
>Let me know what you think before i proceed since i am going
>to be using this approach as a basis for other changes.
>
>cheers,
>jamal
>

>+struct xtables_globals
>+{
>+	unsigned int option_offset;
>+	char *program_version;
>+	char *program_name;
>+	struct xtables_afinfo *afinfo;
>+	struct option *opts;
>+};

These should be const, esp. program_version and program_name.
I added myself a patch now.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux