On Monday 2009-02-09 22:27, jamal wrote: >On Mon, 2009-02-09 at 22:04 +0100, Jan Engelhardt wrote: >> >> I do not think a library should call exit() and cause the main program >> to terminate; >> to this end it might be best to add a >> >> void (*exit_error)(.. >> >> function pointer to the xtables_global struct you are proposing. > >Thanks for the suggestion - it sounds reasonable. >Note, however, grep says there are about 700 references to exit_error() >- so my intent of moving it into xtables.c is for usability more than >anything. Hm you are right; much of the code assumes that exit_error() never returns. We need to stick to that for the time being. >> If you could convert iptables.c and friends to also make use of this, >> that'd be great. > >There are only 3 definitions as far as i can see. If i can convert those >to use that global struct then I should be able to compile that basic >program. Yep. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
