On Sunday 2009-02-01 10:14, David Miller wrote: >> I think that the chunkmap field in struct xt_sctp_info is >> too large: we have 256 chunk types and it's a bitfield, >> so the table should be 256 bits (8 uint32_t) instead >> of 64 uint32_t. >> >> I updated the size of the table, and I did some cosmetic >> changes in SCTP_CHUNKMAP_* macros (use a mask instead of >> a modulo). >> >> netfilter/xt_sctp.h | 30 ++++++++++++++++-------------- >> netfilter_ipv4/ipt_sctp.h | 30 ++++++++++++++++-------------- >> 2 files changed, 32 insertions(+), 28 deletions(-) >> >> Can someone have a look at it ? Please CC me for any replies >> as I'm not on the list. > >Patrick, I assume you got this? At least I got this - and the change would have to be nak'ed because it changes the userspace<->kernel binary stream. If you do such a change, a new match revision is required. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
