Jan Engelhardt wrote: > On Tuesday 2009-01-27 15:29, jamal wrote: >> On Tue, 2009-01-27 at 09:19 -0500, jamal wrote: >> >>> Ok, no problem - let me know when you are done. >> BTW, it would be nice if you commit those patches to the git tree and i >> pull them. > > The proposed changes are at > > git://dev.medozas.de/iptables master > > 92 files changed, 1063 insertions(+), 1135 deletions(-) > > They are pretty broad, but repetitive. > > There are a few functions left. Like exit_error, which still has ties > to the origin program (iptables, ip6tables), to do option freeing for > example. Have not yet thought of how to resolve that. Ideas welcome. I think that you can move functions that are common to iptables and ip6tables like exit_error(), merge_options(), ... and so on to libxtables. I think that the purpose of this libxtables library should be: 1) To provide an API for jamal's tc ipt and your xtables-addon thing (anyone willing to compile their .so files without recompiling iptables). 2) To factorize some code which is common to iptables and ip6tables. -- "Los honestos son inadaptados sociales" -- Les Luthiers -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html