On Wednesday 2009-01-07 21:05, Eric Leblond wrote: >--- a/net/netfilter/nf_log.c >+++ b/net/netfilter/nf_log.c >@@ -172,13 +172,26 @@ static int seq_show(struct seq_file *s, void *v) > { > loff_t *pos = v; > const struct nf_logger *logger; >+ struct nf_logger *t; >+ char loggers_string[256]; >+ int len = 256; An array this big is likely to upset the guys who try to reduce stack usage. <mumble> there ought to be some way to figure out how much space there is left in a seq... </mumble> and if there is enough, just always use seq_printf. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html