Jan Engelhardt wrote:
> commit 67f4e55f28abf2f666c0a0aa874d9421e91d6184
> Author: Jan Engelhardt <jengelh@xxxxxxxxxx>
> Date: Wed Dec 24 20:30:47 2008 +0100
>
> iptables-restore: remove unused --binary flag
>
> Signed-off-by: Jan Engelhardt <jengelh@xxxxxxxxxx>
> ---
> ip6tables-restore.c | 7 +------
> iptables-restore.c | 7 +------
> iptables-save.c | 12 ++----------
> 3 files changed, 4 insertions(+), 22 deletions(-)
>
> diff --git a/ip6tables-restore.c b/ip6tables-restore.c
> index 01bccf7..0920760 100644
> --- a/ip6tables-restore.c
> +++ b/ip6tables-restore.c
> @@ -26,11 +26,10 @@
> #define DEBUGP(x, args...)
> #endif
>
> -static int binary = 0, counters = 0, verbose = 0, noflush = 0;
> +static int counters = 0, verbose = 0, noflush = 0;
>
> /* Keeping track of external matches and targets. */
> static const struct option options[] = {
> - {.name = "binary", .has_arg = false, .val = 'b'},
> {.name = "counters", .has_arg = false, .val = 'c'},
> {.name = "verbose", .has_arg = false, .val = 'v'},
> {.name = "test", .has_arg = false, .val = 't'},
> @@ -45,7 +44,6 @@ static void print_usage(const char *name, const char *version) __attribute__((no
> static void print_usage(const char *name, const char *version)
> {
> fprintf(stderr, "Usage: %s [-b] [-c] [-v] [-t] [-h]\n"
> - " [ --binary ]\n"
> " [ --counters ]\n"
> " [ --verbose ]\n"
> " [ --test ]\n"
> @@ -144,9 +142,6 @@ int main(int argc, char *argv[])
>
> while ((c = getopt_long(argc, argv, "bcvthnM:", options, NULL)) != -1) {
> switch (c) {
> - case 'b':
> - binary = 1;
> - break;
I doubt that someone is using this option, anyhow I think that it would
be better to output a warning message to stderr that says "-b is
deprecated, fix your scripts". Later, we can remove it.
--
"Los honestos son inadaptados sociales" -- Les Luthiers
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
