Re: libxt_rateest: fix segfault

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jan Engelhardt wrote:
commit 48c13b071a7f37ea57f93312c2547d5512b78f3e
Author: Jan Engelhardt <jengelh@xxxxxxxxxx>
Date:   Mon Dec 8 18:23:12 2008 +0100

libxt_rateest: fix segfault

When running `ip6tables -m rateest` without any other arguments,
rateest did segfault.
---
 extensions/libxt_rateest.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/extensions/libxt_rateest.c b/extensions/libxt_rateest.c
index ebea437..f0dd577 100644
--- a/extensions/libxt_rateest.c
+++ b/extensions/libxt_rateest.c
@@ -306,7 +306,7 @@ rateest_final_check(unsigned int flags)
 {
 	struct xt_rateest_match_info *info = rateest_info;
- if (!(info->flags & XT_RATEEST_MATCH_REL))
+	if (info != NULL && !(info->flags & XT_RATEEST_MATCH_REL))
 		info->flags |= XT_RATEEST_MATCH_ABS;

I think we should print an error message instead. The kernel will
refuse it anyways.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux