Jan Engelhardt wrote:
Hi Patrick and list,
when Adam sent his xt_LED, I noticed that he avoided to create an
xt_LED.h and instead had the definition of the blob structs directly in
xt_LED.c and libxt_LED.c. It occurred to me that this has some
implications.
Theoretically, we could kill all {ipt,ip6t,xt}_*.h files in
<kernel>/include/linux/netfilter*/ -- since userspace, usually only
iptables, does not make use of them anyway, but has its own copies.
Yes, for simplicity, we let unifdef run over these headers before
copying them, but then again, when was the last time you had __KERNEL__
in xt_*.h?
I really doubt there are any other userspace programs of these
files at this time. As I see it, these header files make only sense
when you are crafting blobs when interacting with libiptc. I am not
aware of any program making such extensive use of libiptc, probably due
to libiptc having been very closely kept in the iptables garden.
Well, there are a few of us trying to scale the walls :) Some may have
even managed to sneak into the garden, but perhaps the bugspray will
drive them back out again :)
More seriously though I thought your goal was a libiptc that could
wander-out from behind the garden walls? If that were to happen,
wouldn't that want some form of .h files, and perhaps even taking the
copies out of iptables itself?
rick jones
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
