Re: [PATCH 00/09]IPtablestng/Kernel - New Framework For IPtables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Evgeniy Polyakov <zbr@xxxxxxxxxxx>
Date: Tue, 28 Oct 2008 03:00:44 +0300

> On Mon, Oct 27, 2008 at 07:58:33AM +0330, hamid jafarian (hamid.jafarian@xxxxxxxxx) wrote:
> > New Framework for IPtables
> 
> Frankly saying your codying style is way out of expected range of
> allowed glitches, so it is quite hard to review the whole thing. Please
> update it to at least remotely match existing code. Also I noticed you
> do not use list iteration functions sometimes and replaces them with
> direct access to next/prev pointers, which is not a good idea.

And also please remove me from the CC: list as I have zero interest
in these patches.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux