Jan Engelhardt wrote: > On Saturday 2008-10-18 12:13, Patrick McHardy wrote: > >> Jan Engelhardt wrote: >>> commit cc3e81cbbc8a6977cfe614286de16020f9efa3c6 >>> Author: Jan Engelhardt <jengelh@xxxxxxxxxx> >>> Date: Fri Oct 17 10:02:30 2008 -0400 >>> >>> netfilter: use NFPROTO_* constants in NF_HOOK callsites >> This is missing arp, the only place that would qualify as bugfix. >> Please resubmit and add a changelog that explains that is actually >> fixes something. > > I just did that! Or did you already delete the mail and > marc is down? > http://marc.info/?l=netfilter-devel&m=122412130603479&w=2 I think that Patrick means that you have to merge both patches and include the changelog that *explicitly* states that this is not just a cleanup but a bugfix, otherwise it won't get into 2.6.27. BTW, include the Reported-by tag. Ingo Molnar recently told us to do so in all of our patches. I don't care about credits but this is supposed to be "good practise" to encourage testers. -- "Los honestos son inadaptados sociales" -- Les Luthiers -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
