On Wednesday 2008-10-15 15:43, Jesper Bengtsson wrote: >This patch corrects a problem with adding ERROR targets on architectures that don't align data structues, e.g. CRIS. > >Signed-off-by: Jesper Bengtsson <jesper.bengtsson@xxxxxxxx> >--- >Index: linux-2.6/include/linux/netfilter_ipv4/ip_tables.h >=================================================================== >RCS file: /usr/local/cvs/linux/os/linux-2.6/include/linux/netfilter_ipv4/ip_tables.h,v >retrieving revision 1.19 >diff -b -u -p -r1.19 ip_tables.h >--- linux-2.6/include/linux/netfilter_ipv4/ip_tables.h 21 Aug 2008 08:40:42 -0000 1.19 >+++ linux-2.6/include/linux/netfilter_ipv4/ip_tables.h 15 Oct 2008 12:55:31 -0000 >@@ -259,7 +259,7 @@ struct ipt_standard > struct ipt_error_target > { > struct ipt_entry_target target; >- char errorname[IPT_FUNCTION_MAXNAMELEN]; >+ char errorname[IPT_TABLE_MAXNAMELEN]; Resolve the indirect macro - use XT_TABLE_MAXNAMELEN. Fix up IPv6 too? This looks not quite right to me though it is of course one way to achieve to goal.. How about this?: char errorname[XT_ALIGN(XT_FUNCTION_MAXNAMELEN)] is what I would suggest. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html