On Tuesday 2008-10-07 09:06, Patrick McHardy wrote: > Jan Engelhardt wrote: >> With the previous patch moving checks into xtables.c, the checks in >> *_tables can be cleaned out. Also propagate the error code from >> xt_{match,target}_check in the error case instead of always using >> -EINVAL. > > It seems to me this part also belongs in patch 1/2 since we're > doing these checks twice for one revision? > Yes, this was split for easier review, but should ideally be folded or we might get a memory and ref leaks. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html