Hi,
On h, okt 06, 2008 at 04:19:44 +0400, Alexey Dobriyan wrote:
> * drop version.h -- unneeded and file will be needlessly rebuilt.
> * make tproxy_core unloadable
> * use "in" device outright, -- target and match are only in PRE_ROUTING,
> so should avoid dereference.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> ---
>
> net/netfilter/nf_tproxy_core.c | 5 ++++-
> net/netfilter/xt_TPROXY.c | 2 +-
> net/netfilter/xt_socket.c | 2 +-
> 3 files changed, 6 insertions(+), 3 deletions(-)
>
> --- a/net/netfilter/nf_tproxy_core.c
> +++ b/net/netfilter/nf_tproxy_core.c
> @@ -10,7 +10,6 @@
> *
> */
>
> -#include <linux/version.h>
> #include <linux/module.h>
>
> #include <linux/net.h>
> @@ -89,7 +88,11 @@ static int __init nf_tproxy_init(void)
> return 0;
> }
>
> +static void __exit nf_tproxy_exit(void)
> +{
> +}
> module_init(nf_tproxy_init);
> +module_exit(nf_tproxy_exit);
Please don't do this. The module was made unloadable because it attaches a
function pointer to skb's and removing the module while there's an skb in
flight would cause a kernel crash.
Thanks for the other cleanups, though.
--
KOVACS Krisztian
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
