Re: [PATCH 01/16] [NETFILTER]: Re-add missing checkentry calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jan Engelhardt wrote:
On Sunday 2008-10-05 08:50, Patrick McHardy wrote:
Jan Engelhardt wrote:
A previous commit ("Move Ebtables to use Xtables") unfortunately
removed match and target checks in Ebtables. Add it back. Some checks
go into xtables.c as part of consolidation work.
Should I fold this one into the patch that removed them?

I am not always sure of your procedure. When you say "applied, thanks", I have to assume it is already in a non-resettable git tree where folding is impossible.

I'm using stacked git to keep the history clean and bisectable.
So changes are always possible, although doing this creates a few
problems for people having cloned the tree, so I try to only do it
when necessary.

Hence these patches are generally designed for on-top-please.

That makes sense of course, the question was more about whether
it would make it easier for people doing bisections if I fold it.
It applies cleanly on top of that change directly, so it wouldn't
be a real problem.

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux