On Wednesday 2008-09-10 10:23, Patrick McHardy wrote: > Jan Engelhardt wrote: >> But due to continued lack of alignment of the entire thing (e.g. EBT_ALIGN(, >> I cannot rule out that >> alignment-sensitive architectures like sparc64 continue choke on it. >> (Due to lack of such machines, I am unable to test) >> >> What we would need is, IMO, >> >> new_size = old_size + EBT_ALIGN(ebt_mac_wormhash_size(wh); >> h = malloc(new_size); >> >> but this of course breaks the binary interface between userspace and >> kernel. Possible solutions I can think of: >> >> (a) kill ebt_among >> (b) willingly change it and break ABI >> (c) continue planned transformation to Xtables and fix later >> >> Which should it be? > > How about: > > (d) add compat support to ebtables, transform to xtables, > add compat translation That's the same as (c) for me ;-) except that the order is slightly different -- I think the patches would also be smaller if we went for Xtables first, because its structs at least already have the compat members, for example. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
