Re: [RFC] netfilter: Rename ipt_ECN.h to ipt_ecn_target.h (and similar) to avoid file name clash

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jozsef Kadlecsik wrote:
On Sat, 16 Aug 2008, Jan Engelhardt wrote:

On Friday 2008-08-15 18:03, P˙˙teris K˙˙avi˙˙š wrote:

This is a request for comments on the proposal that the following
filename changes (indicative at this point) be made in the
netfilter source code tree, together with correcting the
corresponding references to the files in both source code, the
build system, and wherever else necessary.

The changes are proposed in order to avoid file name clashes on
filesystems that do not allow two files to have names that differ
only in the case of their letters:

include/linux/netfilter/xt_CONNMARK.h => xt_connmark_target.h
[...]

As I see it, this will already be addressed by merging complementary
code into one source file (e.g. MARK, mark, CONNMARK, connmark
all into a big new xt_mark.c), to reduce (a) amount of files
and (b) build time.
[...]

That is half of the story: we encode the functionality (match/target) in the case of the (file)name and there are targets which have got no match counterpart and thus no natural lowercase filename to merge into it. So the directory tree still will be broken on case-insensitive filesystems. If as a side effect of some real internal changes netfilter becomes compatible with case-insensitive filesystems, that's fine. However, I object changes just for the sake to be compatible with such horrid filesystems.

I agree. Without compat files this would also break compilation
of old userspace, so this is not an option anyways.

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux