>----- Oorspronkelijk bericht ----- >Van: Jan Engelhardt [mailto:jengelh@xxxxxxxxxx] >Verzonden: woensdag, augustus 6, 2008 10:44 PM >Aan: bdschuym@xxxxxxxxxx >CC: 'Netfilter Developer Mailing List' >Onderwerp: ebtables "|&" mixup > >Hi, > > >I have just spotted > > if (BASE_CHAIN && (natinfo->target | ~EBT_VERDICT_BITS) == >EBT_RETURN) > >in ebtables's ebt_nat.c (there may be other places), I think this should >be & ~EBT_VERDICT_BITS instead, should not it? Hi Jan, Bits from the 'target' member can be used for other purposes, since the number of targets is limited. The checks you mention were added when support for writing the ip address to an arp header were added (keeping full backwards compatibility). They are correct. See http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=d12cdc3ccf140bd2febef1c1be92284571da983f cheers, Bart -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
