Re: netfilter 03/03: xt_hashlimit: fix race between htable_destroy and htable_gc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Thu, 31 Jul 2008 08:33:16 +0200 (MEST)

> netfilter: xt_hashlimit: fix race between htable_destroy and htable_gc
> 
> Deleting a timer with del_timer doesn't guarantee, that the
> timer function is not running at the moment of deletion. Thus
> in the xt_hashlimit case we can get into a ticklish situation
> when the htable_gc rearms the timer back and we'll actually
> delete an entry with a pending timer.
> 
> Fix it with using del_timer_sync().
> 
> AFAIK del_timer_sync checks for the timer to be pending by
> itself, so I remove the check.
> 
> Signed-off-by: Pavel Emelyanov <xemul@xxxxxxxxxx>
> Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx>

Also applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux