[ULOGD2 PATCH 0/11] Big warning hunting.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

As promised, here's the patchset resulting in hunting the cause of gcc warning.

Only a few mistakes and problems were found but the warning hunt was
necessary.
Main issues are fixed in the patch:
 * Cleanly stop SYSLOG module: close log function was not called.
 * Suppress twice defined key: printpkt was defining twice the same key.
 * Fix some initialisation: ulogd.c had some problem with initialisation.

I've added the option "-Wno-unused-parameter" to CFLAGS to avoid some unfixable
warnings.

If we omit IPFIX that I did not touch, the code is warning free.

Pathset statistics:
 configure.in                              |    2 +-
 filter/raw2packet/ulogd_raw2packet_BASE.c |    5 +----
 filter/ulogd_filter_IFINDEX.c             |    2 +-
 filter/ulogd_filter_IP2BIN.c              |    4 ++--
 filter/ulogd_filter_MARK.c                |    4 ++--
 filter/ulogd_filter_PWSNIFF.c             |    4 ++--
 include/libipulog/libipulog.h             |    2 +-
 input/packet/ulogd_inppkt_ULOG.c          |    2 +-
 libipulog/libipulog.c                     |    4 ++--
 libipulog/ulog_test.c                     |    2 +-
 output/mysql/ulogd_output_MYSQL.c         |    4 +---
 output/pgsql/ulogd_output_PGSQL.c         |    5 ++---
 output/ulogd_output_LOGEMU.c              |    2 +-
 output/ulogd_output_NACCT.c               |    8 ++++----
 output/ulogd_output_SYSLOG.c              |    8 ++++++--
 src/conffile.c                            |    4 ++--
 src/ulogd.c                               |   16 +++++++---------
 util/db.c                                 |   16 +++++++---------
 util/printflow.c                          |    8 ++++----
 util/printpkt.c                           |   15 ++++++---------
 20 files changed, 54 insertions(+), 63 deletions(-)

BR,
--
Eric Leblond
INL: http://www.inl.fr/
NuFW: http://www.nufw.org/
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux