Re: [ULOGD2 PATCH 0/4] Misc cleaning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pablo Neira Ayuso wrote:
Eric Leblond wrote:
The main concern here is about IPFIX which is in really bad shape. I've fix
some major error in one of the patch but it remains untested for now and I
don't think it can work properly.

Indeed. It's broken Do you plan to look into this? If not, I'll fix it
myself. Please, let me know since I don't want to duplicate work. Do you
also plan to send me a patch to fix all those warnings?

I think would prefer to enable the warnings that make sense
individually, -Wextra includes lots if crap like "%s expects
type char *, but argument is void *" or signedness warnings
that are compiler-detectable irrelevant 50% of the time.

OTOH a lot of the warnings in the current -git version indicate
that the code really needs more love, like missing return values
etc, so it seems we really want *some* of the new warnings.

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux