On Thursday 2008-07-03 18:29, Phil Oester wrote:
>
>> >+static int route_parse(int c, char **argv, int invert, unsigned int *flags,
>> >+ const void *entry, struct xt_entry_match **match)
>> >+{
>> >+ struct xt_route_info *info = (struct xt_route_info *) (*match)->data;
>> >+ unsigned int value;
>> >+
>> >+ check_inverse(optarg, &invert, &optind, 0);
>>
>> I would not bother supporting intraplaced ! at all. Just remove that line.
>
>Sorry..."intraplaced"?
intra = within/inside
There is
iptables ! -s 192.168.1.5 (normal)
and
iptables -s ! 192.168.1.5 (intraplaced)
Considering that most extensions only support the normal form,
I would not add any more intraplace support to new modules
to reduce the number of supported styles. Real robustness can
only be achieved when one is strict.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
