On Monday 2008-06-30 20:44, Joonwoo Park wrote: >> Why not just doing it this way? >> >> >> enum { >> XT_STRING_INVERT = 1 << 0, >> XT_STRING_ICASE = 1 << 1, >> }; >> >> struct xt_string_info { >> ... >> union { >> uint8_t invert; >> uint8_t flags; >> }; >> ... >> }; >> >> > >Not bad for me, >I think invert might be removed and flags can contain XT_STRING_INVERT as well. Right, since we copy eader files anyway, we can just make it uint8_t flags without the union. >But I guess we should do version checking between user-space and >kernel more strictly whatever. That is what we have '.revision' in xt_match/xt_target for. In this case however it should be fine with just flags. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html