Pablo Neira Ayuso wrote:
Patrick McHardy wrote:
Patrick McHardy wrote:
A few minor nits:
...
One more thing: the patch still doesn't follow the correct
netlink semantic for notifations on changes triggered by
userspace I described in the review of the first version
of this patch.
Please always mention which changes requested during a
review were made and which weren't (any why) when sending
updated versions.
Sorry, there's no particular reason, I forgot to include this. With
regards to nlmsg_report/nlmsg_notify, I just noticed that the echo
cannot be unset for destroy messages since we call nf_conntrack_event()
inside destroy_conntrack().
Mhh .. its not pretty, but one thing that might work is
deliver the event manually and then set the DYING bit
manually to avoid further event delivery for the entry.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
