David Miller wrote:
Forwarding to netfilter-devel where this belongs...
Thanks.
In this patch, these three fixes were made in net/ipv4/netfilter/ip_queue.c: 1) No need to perform data_len = 0 in the switch command, since data_len is initialized to 0 in the beginning of the method ,ipq_build_packet_message(). 2) We can reach nlmsg_failure only from one place; skb is sure to be NULL when getting there; since skb is NULL, there is no need to check this fact and call kfree_skb(). 3) Add #ifdef CONFIG_PROC_FS when removing the VFS entry, proc_net_remove(&init_net, IPQ_PROC_FS_NAME); Regards, Rami Rosen Signed-off-by: Rami Rosen <ramirose@xxxxxxxxx>
1) also affects ip6_queue and nfnetlink_queue 2) also affects ip6_queue 3) is unnecessary since proc_net_remove is a NOP without CONFIG_PROC_FS Please update your patch to also change ip6_queue and nfnetlink_queue where applicable. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
