Re: [PATCH] simplify list handing in ifname2index infrastructure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Thursday, 2008 May 22 at 15:02:53 +0200, Pablo Neira Ayuso wrote:
> Eric Leblond wrote:
> > Hello,
> > 
> > On Thursday, 2008 May 22 at 14:19:12 +0200, Pablo Neira Ayuso wrote:
> >> Hi!
> >>
> >> The patch attached simplifies the ifname2index list handling by using
> >> linux list and it introduces minor cleanups such as remove iftb_log()
> >> calls. This patch also fixes the leak in the nlif_close path (we forgot
> >> to release the ifindex nodes from the hashes) that Anton has reported.
> >>
> >> Slightly tested here. If you are OK with it I'll apply it asap.
> > 
> > Maybe, this patch is a little too much for a code which should disappear for
> > libnl ?
> 
> Well, the current code is broken and we have to fix it anyway. If you
> don't have any other objection I'll apply it asap.

My patch fixes the issue without too much changes and we use current
code in NuFW without trouble for years. As we have only one open, we
don't suffer from the memory leak.

BR,
-- 
Eric Leblond
INL: http://www.inl.fr/
NuFW: http://www.nufw.org/
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux