On Wed, 21 May 2008 14:45:50 -0700 (PDT) David Miller wrote: > This needs to go in via whatever tree adds the linux/rculist.h header file, > which isn't net-next-2.6 as far as I can tell. :-) Sure, makes sense. Looks like it's some sched/auto-sched tree/branch if I'm reading correctly. Ingo, is there a sched tree that add rculist.h file? If so, one of its users needs to #include it. Patch below. --- From: Randy Dunlap <randy.dunlap@xxxxxxxxxx> nf_conntrack_helper users rcu hlist functions so it needs to #include rculist.h. linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: implicit declaration of function 'hlist_for_each_entry_rcu' linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: 'hnode' undeclared (first use in this function) linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: (Each undeclared identifier is reported only once linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: for each function it appears in.) linux-next-20080521/net/netfilter/nf_conntrack_helper.c:58: error: expected ';' before '{' token linux-next-20080521/net/netfilter/nf_conntrack_helper.c:50: warning: unused variable 'mask' linux-next-20080521/net/netfilter/nf_conntrack_helper.c:74: error: 'hnode' undeclared (first use in this function) linux-next-20080521/net/netfilter/nf_conntrack_helper.c:74: error: expected ';' before '{' token linux-next-20080521/net/netfilter/nf_conntrack_helper.c:117: error: implicit declaration of function 'hlist_add_head_rcu' linux-next-20080521/net/netfilter/nf_conntrack_helper.c:133: error: implicit declaration of function 'hlist_del_rcu' filter/nf_conntrack_helper.o] Error 1 Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx> --- net/netfilter/nf_conntrack_helper.c | 1 + 1 file changed, 1 insertion(+) --- linux-next-20080521.orig/net/netfilter/nf_conntrack_helper.c +++ linux-next-20080521/net/netfilter/nf_conntrack_helper.c @@ -10,6 +10,7 @@ */ #include <linux/types.h> +#include <linux/rculist.h> #include <linux/netfilter.h> #include <linux/module.h> #include <linux/skbuff.h> -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html