Re: [PATCH 3/8] [NETFILTER]: rename NF_ARP to NFPROTO_ARP and assign a non-clashing value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jan Engelhardt wrote:
On Wednesday 2008-04-09 15:51, Patrick McHardy wrote:
So since that just came to my mind, how about using the
somewhat odd one NFPROTO_TOTAL?
How about just using MAX the way a maximum is defined?


MAX is just ambiguous.

 - the maximum /number/ [i.e. counting things] of something or
 - the maximum [array index] /value/

and apparently noone encoded the intent of MAX into their
constant's name when writing it.

Well, I'm sick of this discussion. MAX is the highest value,
NUM is the number of items. I'm aware that people seem to
have problems understanding this, but that is no reason
to further the confusion.

BTW, these values *do* need to be exported to userspace
for nfnetlink.

Make a public vote on lkml if you dare, or I will >>:-]

Don't CC me or I might get into an unpleasant mood.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux