Re: [PATCH 08/24] [NETFILTER]: rename NF_ARP to AF_ARP and assign a non-clashing value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



YOSHIFUJI Hideaki / $B5HF#1QL@ wrote:
In article <47F4D8F3.70606@xxxxxxxxx> (at Thu, 03 Apr 2008 15:17:39 +0200), Patrick McHardy <kaber@xxxxxxxxx> says:

:
  #define AF_ECONET    19    /* Acorn Econet            */
  #define AF_ATMSVC    20    /* ATM SVCs            */
 +#define AF_ARP        21    /* Address Resolution for IPv4    */
:
I don't like exporting this since, as you say, userspace doesn't
need it and arp isn't an address family. I would suggest to
:

Why not #ifdef __KERNEL__ .. #endif?
Or just add a comment not to use the value.


It sets a bad example to add new non-families there as well.
We're dimensioning lots of things using AF_MAX, so its better
to avoid misuse.

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux