Re: [PATCH 08/24] [NETFILTER]: rename NF_ARP to AF_ARP and assign a non-clashing value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Thursday 2008-04-03 15:44, Patrick McHardy wrote:

>  I don't like exporting this since, as you say, userspace doesn't
>  need it

 Somehow you have to say that an extension if for arp only.
 We could abuse ETH_P_ARP, but using just the same name and value
 across both user and kernelspace seems just more logical.

 static struct xtables_target new_arp_mangle = {
     .family = ETH_P_ARP,
 };

Whats the problem with moving NF_ARP outside userspace
visibility and defining it to AF_MAX + 1?

I guess it would work. Given that my currently running kernel
did not break on removing NF_ARP entirely and substituting it
by PF_ARP=21...
can we at least go for a more verbose name like NFPROTO_ARP?
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux