Re: [PATCH 04/24] [NETFILTER]: remove unused ARPT_ALIGN indirection macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jan Engelhardt wrote:

On Thursday 2008-04-03 13:49, Patrick McHardy wrote:
Jan Engelhardt wrote:
 Signed-off-by: Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx>
 ---
  include/linux/netfilter_arp/arp_tables.h |    4 ----
  1 files changed, 0 insertions(+), 4 deletions(-)

 diff --git a/include/linux/netfilter_arp/arp_tables.h
 b/include/linux/netfilter_arp/arp_tables.h
 index 0e6b5e1..1cb698b 100644
 --- a/include/linux/netfilter_arp/arp_tables.h
 +++ b/include/linux/netfilter_arp/arp_tables.h
@@ -274,8 +274,6 @@ extern unsigned int arpt_do_table(struct sk_buff *skb,
        const struct net_device *out,
        struct xt_table *table);

 -#define ARPT_ALIGN(s) XT_ALIGN(s)

This is exported to userspace, so I can't apply this. I'm
also reverting 03/24 since that also breaks userspace.

I would not expect anything but arptables to use these macros;
and actually arptables has its own copies of the .h files much
like iptables does. Just my 13 cents.


I wouldn't be so sure of that, there also have been other programs
using the iptables API, besides the fact that arptables can also
be compiled against the current headers. Speculation is not enough
for breaking an interface, sorry.

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux