Hi Patrick,
On Thu, 6 Mar 2008, Patrick McHardy wrote:
> > @@ -95,7 +85,7 @@ void *__nf_ct_ext_add(struct nf_conn *ct
> > newlen = newoff + t->len;
> > rcu_read_unlock();
> >
> > - if (newlen >= ct->ext->real_len) {
> > + if (newlen >= ksize(ct->ext)) {
>
> This needs to look at the currently allocated size, otherwise
> it will always realloc when adding new extensions after having
> used up ksize(ct->ext) space.
Lets say you
p = kmalloc(8, ...);
Then ksize(p) will return the currently allocated size which is 32 bytes
when page size is 4 KB, and not 8 bytes. So it should be equivalent of
what the current code does.
What am I missing here?
Pekka
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
