David Woodhouse wrote:
On Tue, 2008-02-19 at 15:45 +0100, Patrick McHardy wrote:
That would break iptables compilation, which already includes
linux/in.h in some files. I guess the best fix for now is to
include netinet/in.h in busybox and long-term clean this up
properly.
It looks like iptables is fairly broken anyway:
make[1]: Entering directory `/home/dwmw2/working/extras/iptables/devel/iptables-1.4.0'
Unable to resolve dependency on linux/compiler.h. Try 'make clean'.
Extensions found:
make[1]: Leaving directory `/home/dwmw2/working/extras/iptables/devel/iptables-1.4.0'
error: Bad exit status from /var/tmp/rpm-tmp.32057 (%build)
Yes, that was a bug in the lastest release. We need to
release a 1.4.1 version or something like that, but I'm
not too familiar with the release process, so I haven't
done this so far.
Anyway, I just committed this patch to iptables to remove
the compiler.h inclusions.
Index: include/linux/netfilter_ipv6/ip6_tables.h
===================================================================
--- include/linux/netfilter_ipv6/ip6_tables.h (Revision 7376)
+++ include/linux/netfilter_ipv6/ip6_tables.h (Arbeitskopie)
@@ -15,7 +15,6 @@
#ifndef _IP6_TABLES_H
#define _IP6_TABLES_H
-#include <linux/compiler.h>
#include <linux/netfilter_ipv6.h>
#include <linux/netfilter/x_tables.h>
Index: include/linux/netfilter.h
===================================================================
--- include/linux/netfilter.h (Revision 7376)
+++ include/linux/netfilter.h (Arbeitskopie)
@@ -1,8 +1,6 @@
#ifndef __LINUX_NETFILTER_H
#define __LINUX_NETFILTER_H
-#include <linux/compiler.h>
-
/* Responses from hook functions. */
#define NF_DROP 0
#define NF_ACCEPT 1
Index: include/linux/netfilter_ipv4/ip_tables.h
===================================================================
--- include/linux/netfilter_ipv4/ip_tables.h (Revision 7376)
+++ include/linux/netfilter_ipv4/ip_tables.h (Arbeitskopie)
@@ -15,7 +15,6 @@
#ifndef _IPTABLES_H
#define _IPTABLES_H
-#include <linux/compiler.h>
#include <linux/netfilter_ipv4.h>
#include <linux/netfilter/x_tables.h>
