Peter Warasin wrote:
> This patch adds the ebtables nflog watcher to the
> kernel in order to allow ebtables log through the
> nfnetlink_log backend.
This seems mostly fine to me. A few minor comments:
> +#define EBT_NFLOG_PREFIX_SIZE 30
People found the 30 character limit to small for iptables,
which is why I increased it to 64 in NFLOG. For consistency
it would be better to use the same value here in my opinion.
> +static struct ebt_watcher nflog = {
This could be __read_mostly.
If you'll resend the patch based on net-2.6.26 I'll queue it
if Bart has no objections.
-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
