Re: [PATCH 4/5] adds AF_BRIDGE support to IP2STR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

This patchset is fine but

On Monday, 2008 February 11 at 23:07:57 +0100, Peter Warasin wrote:
> This patch make the ip address string converter AF_BRIDGE
> compatible and add ip address ARP keys in order to make
> them also convert.
> +	[KEY_ARP_SPA] = {
> +		.type = ULOGD_RET_IPADDR,
> +		.flags = ULOGD_RETF_NONE,
> +		.name = "arp.saddr",
> +	},
> +	[KEY_ARP_TPA] = {
> +		.type = ULOGD_RET_IPADDR,
> +		.flags = ULOGD_RETF_NONE,
> +		.name = "arp.daddr",
> +	},

you defined here arp.daddr as ULOGD_RET_IPADDR although you've defined it in
BASE plugin as:
	[KEY_ARP_SPA] = {
		.type = ULOGD_RET_RAW,
		.flags =
			ULOGD_RETF_NONE,
		.name =
			"arp.saddr",
	},

This should work in current state code but it is only luck.

BR,
-- 
Eric Leblond
INL: http://www.inl.fr/
NuFW: http://www.nufw.org/

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux