Tseng, Kuo-Lang wrote on Monday, February 11, 2008 9:59 AM: > Bart De Schuymer wrote on Sunday, February 10, 2008 9:21 AM: > >> Op vr, 08-02-2008 te 16:01 -0800, schreef Tseng, Kuo-Lang: >>> Bart De Schuymer wrote on Friday, February 08, 2008 10:21 AM: >>> >>>> Hi Kuo, >>>> >>>> Thanks for your patch. The patch looks ok. Tiny comment: the header >>>> diffs belong in the kernel patch and the userspace patch lacks a >>>> man page update. Seems like we'll need a merge of the two kernel >>>> patches and extra userspace code. >>>> >>>> I was gonna give my say about posting to netfilter-devel only, >>>> without userspace code, but I guess I'm better off restraining >>>> myself from doing that. >>>> >>>> cheers, >>>> Bart >>> >>> Thanks. I have attached an updated userspace patch that includes the >>> missing man page update and removed the header diffs. >> >> It would be better if the ipv6 address and traffic class matching >> were implemented in the patch. So I'm going to wait for that. Is >> there any reason why you didn't do this in the first place? > We wanted to keep the first patch small for the review. Once the first > patch is merged in, the v6 address and traffic class can be added > after that. Hi Jan, have you posted the corresponding patch to ebtables-devel for the kernel patch you posted in here http://marc.info/?l=netfilter-devel&m=120182168424052&w=2 ? If not, I can add the code and send an updated patch to ebtables-devel to make the v6 support more complete as Bart suggested. We also need to merge the two kernel patches (your above one and the one I sent last Friday). Has your kernel patch been pushed in? If not, I'll add my part on top of yours and send an updated patch to netfilter-devel. What do you think? To quickly summarize what we got: - You above kernel patch implements matches for TFCLASS, FLOWLBL, NEXTHDR (w/o skipping ext. header), H- OPLIMIT, SRCADDR, and DSTADDR. - My kernel patch implements matches for PROTOCOL (w/ ext. header skipped), DPORT, and SPORT and logging for v6. - My user ebtables patch implements parsing for PROTO, SPORT, and DPORT. - To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
