Eric Leblond wrote: > Some macros were defined several time. This was the case of GET_VALUE, > pp_is_valid. This patch puts the definition in ulogd.h and fixes the > definition of pp_is_valid which was wrong (causing segfault by acessing to > fields at NULL). I like these sort of cleanups a lot. I think that the code of the input handlers would be also much nicer if we cook some macros to setup values and flags of the ulogd_keys. Applied. Thanks Eric. -- "Los honestos son inadaptados sociales" -- Les Luthiers - To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html