Re: [PATCH 01/34] Introduce new SQL schema.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Applied. Thanks. BTW, one question:

Eric Leblond wrote
> @@ -88,25 +90,8 @@ static int sql_createstmt(struct ulogd_pluginstance *upi)
>  		return -ENOMEM;
>  	}
>  
> -	if (mi->schema)
> -		sprintf(mi->stmt, "insert into %s.%s (", mi->schema, table);
> -	else
> -		sprintf(mi->stmt, "insert into %s (", table);
> -	mi->stmt_val = mi->stmt + strlen(mi->stmt);
> -
> -	for (i = 0; i < upi->input.num_keys; i++) {
> -		if (upi->input.keys[i].flags & ULOGD_KEYF_INACTIVE)
> -			continue;
> -
> -		strncpy(buf, upi->input.keys[i].name, ULOGD_MAX_KEYLEN);	
> -		while ((underscore = strchr(buf, '.')))
> -			*underscore = '_';
> -		sprintf(mi->stmt_val, "%s,", buf);
> -		mi->stmt_val = mi->stmt + strlen(mi->stmt);
> -	}
> -	*(mi->stmt_val - 1) = ')';
> +	sprintf(mi->stmt, "CALL %s(", procedure);
>  
> -	sprintf(mi->stmt_val, " values (");
>  	mi->stmt_val = mi->stmt + strlen(mi->stmt);
>  
>  	ulogd_log(ULOGD_DEBUG, "stmt='%s'\n", mi->stmt);

Since now we use user-defined procedures and call them, we have to
remove the old mysql and pgsql definitions from doc/ as well which does
not use it, and what about sqlite3?

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers
-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux