Re: [PATCH] Re: [ULOGD RFC 08/30] NFCT: rework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Eric Leblond <eric@xxxxxx> writes:

Hi Eric,

> You changelog is not complete as it did not mention important
> modification of the output keys.

Sorry, my way of presenting all those changes in very few patches was
intentional, I just tried to keep the number of patches small.

> Accounting is done here for both side of connection ...

Yes, principally this should be a configuration option sooner or later,
but this is what I needed at the time of writing that patch.  The former
way might not be what someone would expect though.  But sure, that change
should have been documented somewhere.

I'll provide a patchset which stuffs all NFCT-related patches into one.
Therein contained are two small changes which basically root from
Pablo Neiras suggestions.

As my NFCT changes currently still depend on one small patch to
libnetfilter-conntrack and Pablo seems quite reluctant to apply that
I'll suggest in my next announcement to apply all but the NFCT changes.
I would like to solve that issue by switching to libnl soon.

However, that switch only makes sense if the other netlink users (NFLOG,
ifi) are switched as well.

If Patrick decides to apply that big patch (retaining compatibility of
output keys of course) I'm fine.  If not I would have to do a gradual
switch to the new code base, but then preferably switching to libnl on
the go.

Thanks for reviewing!

 /holger

-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux