Holger Eitzenberger wrote:
Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> writes:
Well, this NFCT stuff is a big hack. I'm sure that you have solved
several issues with those patches but sorry, I don't like them at all.
There's several parts of conntrackd that we could use to rework this eg.
an implementation of a generic hash table in conntrackd that we can
reuse and nfnl_recv_msgs looks very similar to nfnl_catch, etc. Also,
the ENOBUFS handling is still a mess. I'm better keeping back these NFCT
patches. I'll try to give some spins to it.
Hi Pablo,
are you talking about this particular patch or the end result after
applying all of the NFCT patches?
Also note that IMO this particular patch turned a non-working NFCT
solution into some better-working solution. I just suggest to
comment on the final NFCT code and not on this one. Thanks.
I agree, this code has bitrotten for too long, I'm happy about
any progress. Any objections should be clearly stated please.
-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
