[NETFILTER]: nf_conntrack_netlink: fix unbalanced locking Properly drop nf_conntrack_lock on tuple parsing error. Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx> --- commit 9813002a577062723e68ac1da712de25f7998f1e tree 3e9798a85beddb21ab8410d63050fa0567dfd6f4 parent ec8971e984194b97af037d06dc40a23f9581276b author Patrick McHardy <kaber@xxxxxxxxx> Tue, 29 Jan 2008 16:22:10 +0100 committer Patrick McHardy <kaber@xxxxxxxxx> Wed, 30 Jan 2008 21:03:05 +0100 net/netfilter/nf_conntrack_netlink.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c index 38141f1..bdae292 100644 --- a/net/netfilter/nf_conntrack_netlink.c +++ b/net/netfilter/nf_conntrack_netlink.c @@ -1237,7 +1237,7 @@ ctnetlink_new_conntrack(struct sock *ctnl, struct sk_buff *skb, CTA_TUPLE_MASTER, u3); if (err < 0) - return err; + goto out_unlock; master_h = __nf_conntrack_find(&master, NULL); if (master_h == NULL) { - To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html