Re: [NETFILTER]: xt_TCPMSS: Consider reverse route's MTU in clamp-to-pmtu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Jan 23 2008 23:29, Patrick McHardy wrote:
>> +static u_int32_t tcpmss_reverse_mtu4(const struct iphdr *iph)
>> +{
>> +	struct flowi fl = {.nl_u = {.ip4_u = {
>> +		.daddr = iph->saddr,
>> +		.tos   = RT_TOS(iph->tos),
>>   
>
> This doesn't make much sense, we don't know the ToS value
> that will be used in the reverse direction.

Usually it will be the same TOS with default setups.
Interactive SSH sessions for example set IPTOS_LOWDELAY,
on both sides.

> use routing rules based on source address, iif etc., so I
> think we should make this optional.

iif yes; should be a matter of in->ifindex or so.


thanks,
Jan

-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux