On 2008/01/23 13:07, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > My experience is that synchronization software is a bit hard because > bugs are somehow more difficult to detect (you need a good testbed > and QA testing requires a considerable amount of time). If we > introduce more source code lines, chances to introduce bugs > increase, for that reason I try to keep it as simple as possible. I understand, but think about how many critical bugs we fixed in this so simple 200 lines alarm implementation. libevent has proven quite stable in the past, many daemons use it nowadays. We not only use it for alarms, but also for socket events (local_server, nfnetlink) and for signal handlers. There is the decision between well-tested but complex external code, and on the other hand untested new code, which is simple currently but might grow in the future. By the way, the libevent migration is not completely finished with my patch, run() should be replaced with event_dispatch(), but for this, STATE(mode)->run() has to be rewritten to be event driven. I believe this rewrite could make conntrackd even better and cleaner (and faster), even if we do not use libevent. Max - To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
