Op zo, 20-01-2008 te 19:30 +0100, schreef Jan Engelhardt: > On Jan 20 2008 19:07, Bart De Schuymer wrote: > >Op zo, 20-01-2008 te 18:34 +0100, schreef Jan Engelhardt: > >> "Ugh." I do not think ebtables(8) should depend on such macros. > >> iptables(8) does not do that either. > >> What good would those macros be for? It is not like the module names > >> would be changing anyway (one purpose of macros - to reduce the number > >> of places where you have to change things iff things change). > > > >We are talking about EBT_ENTRY_ITERATE and the like, right? > >I didn't see your patch, but even the kernel code uses the ITERATE > >macros more than once. > > > No, just the name macros: I see, well they are used in the userspace tool. The point is not that the value can change, the point is that the value is part of the interface between userspace and kernel and it prevents using "magical strings" (as in magical numbers): information that a programmer cannot know by just looking at the header files (the interface). Of course this is completely academic, but my taste made me make that choice. > >packet vs Packet, rate vs Packet, ... But this is not worth the > >bandwidth at all, I should just shut up :) > > I need to pay more attention. I was kinda missing out on "after > Ebtables". > > Well, here you go. Thanks, Bart - To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
