Re: [PATCH 1/2] [NETFILTER]: xt_TCPMSS: Consider incoming device's MTU in clamp-to-pmtu

[Patrick McHardy <kaber@xxxxxxxxx>]

Jan Engelhardt wrote:
> commit 1ed78bbf75455dfe77a028f2da2f351cff4028f2
> Author: Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx>
> Date:   Sun Jan 20 13:13:33 2008 +0100
>
>     [NETFILTER]: xt_TCPMSS: Consider incoming device's MTU in clamp-to-pmtu
>     
>     The TCPMSS target in Xtables should consider the MTU of the input
>     device on forwarded packets as part of the path MTU.
>     
>     Point in case: IN=ppp0, OUT=eth0. MSS set to 1460 in spite of MTU of
>     ppp0 being 1392.


> -				   sizeof(*ipv6h) + sizeof(struct tcphdr));
> +	ret = tcpmss_mangle_packet(skb, targinfo, (in == NULL) ? ~0U : in->mtu,
> +	      tcphoff, sizeof(*ipv6h) + sizeof(struct tcphdr));


This is slightly better than what we currently have, but it should
actually use the MTU from the dst_entry for the reverse direction.
I've tried adding this not too long ago and ran into some problems,
but I can't remember the exact details.
-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html