Re: [PATCH] Fix CONNMARK mask value demolition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Peter Warasin wrote:
This patch fixes the problem that the CONNMARK mask value
has been set to 0 whenever the CONNMARK target options has not
been the last options to be processed.

> @@ -64,13 +64,12 @@
>  	struct xt_connmark_target_info *markinfo
>  		= (struct xt_connmark_target_info *)(*target)->data;
>
> -	markinfo->mask = 0xffffffffUL;
> -
>  	switch (c) {
>  		char *end;
>  	case '1':
>  		markinfo->mode = XT_CONNMARK_SET;
>
> +		markinfo->mask = 0xffffffffUL;

Good catch, but don't we also need set the mask for --save-mark
and --restore-mark? I would suggest to move the initialzation
to a ->init() function.

-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux