Re: [PATCH 21/27] Convert unfixated types to fixated ones

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Jan 8 2008 16:52, Patrick McHardy wrote:
> Jan Engelhardt wrote:
>> commit 69855da1bb8257b215c83a72edd0c67bd7810fa5
>> Author: Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx>
>> Date:   Wed Jan 2 18:30:30 2008 +0100
>> 
>>     [NETFILTER]: Convert unfixated types to fixated ones.
>>     
>>     The use of an unfixated type like "int" is dangerous, its size may
>>     change in future (imagine 128-bit or ILP64 compilation) -- "long"
>>     already has this problem which is differently-sized on x86_32 and
>>     x86_64. Switch "int" to "int32_t" to prepare against future compiler
>>     changes.
>
>
> If that really happens a lot of things would break, so I don't
> really see the point. It also changes types like char whose
> size won't ever change.
>
int8_t would serve as an intent annotation that the member is used
for a numeric value rather than a character. Well, never mind.
-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux