On Jan 4 2008 15:53, Patrick McHardy wrote: > > Applied, but > >> #include <linux/netfilter/nf_conntrack_tuple_common.h> >> -#include <linux/in.h> >> +#ifdef __KERNEL__ >> +# include <linux/in.h> >> +#endif > > Is that really necessary? I would prefer the only in-kernel user of this > file to include it directly. Or simply include netfilter.h, which seems > necessary for nf_inet_addr anyway. > With this #include, we grab the definition for 'struct in_addr'. Yes it is necessary otherwise iptables fails to compile, because struct in_addr is already sourced from netinet/in.h. If you have a better idea, please share it. Perhaps doing #include <linux/in.h> in xt_conntrack.c would resolve it. I will see to that (if you do not already will take care of that) once I received your updated git tree. thanks, Jan - To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
