Re: [PATCH 2/27] Change semantic of mask value in xt_TOS

[Patrick McHardy <kaber@xxxxxxxxx>]

Jan Engelhardt wrote:
> commit 4fd5dd02c10be25f59155d127d3ea6de17703946
> Author: Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx>
> Date:   Wed Jan 2 17:35:23 2008 +0100
>
>     [NETFILTER]: Change semantic of mask value in xt_TOS
>     
>     This patch changes the behavior of xt_TOS v1 so that the mask value
>     the user supplies means "zero out these bits" rather than "keep these
>     bits". This is more easy on the user, as (I would assume) people keep
>     more bits than zeroing, so, an example:
>     
>     	Action:     Set bit 0x01.
>     	before (&): iptables -j TOS --set-tos 0x01/0xFE
>     	after (&~): iptables -j TOS --set-tos 0x01/0x01
>     
>     This is not too "tragic" with xt_TOS, but where larger fields are used
>     (e.g. proposed xt_MARK v2), `--set-xmar 0x01/0x01` vs. `--set-xmark
>     0x01/0xFFFFFFFE` really makes a difference. Other target(!) modules,
>     such as xt_TPROXY also use &~ rather than &, so let's get to a common
>     ground.
>     
>     (Since xt_TOS has not yet left the development tree en direction to
>     mainline, the semantic can be changed as proposed without breaking
>     iptables.)

Applied, thanks Jan.
-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html