On Nov 27 2007 01:12, Patrick McHardy wrote:
>Jan Engelhardt wrote:
>>On Nov 26 2007 08:24, Patrick McHardy wrote:
>>
>>>Jan Engelhardt wrote:
>>>>+struct xt_tee_target_info {
>>>>+ union {
>>>>+ /* Address of gateway */
>>>>+ u_int32_t gateway_v4;
>>>>+ u_int32_t gateway_v6[4];
>>>
>>> These should be __be32 or simply use in_addr/in6_addr. At some
>>> point it would be good to have a nf_inet_addr type (or something
>>> net/-wide) so we don't have to introduce more and more of these.
>>
>> In include/net/netfilter/nf_conntrack_tuple.h there is
>> nf_conntrack_address, which would be perfectly suited for the task.
>> But I am not sure if I can use that, since it would have to be
>> exported to userspacce (would probably need to move the union to
>> include/linux/netfilter/ too). Thoughts?
>
> And the name doesn't really match. I'd prefer to type for all of
> netfilter and then have conntrack use that one.
>
About nf_inet_addr; does any userspace program depend on
nf_conntrack_address? If so, I would have to add some #defines to remain
compat.
-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
